Change in osmo-ttcn3-hacks[master]: pcu: Set up PCU TDMA clock by sending initial DATA.ind

fixeria gerrit-no-reply at lists.osmocom.org
Fri Mar 12 13:52:29 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324 )

Change subject: pcu: Set up PCU TDMA clock by sending initial DATA.ind
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324/2/pcu/PCUIF_Components.ttcn 
File pcu/PCUIF_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324/2/pcu/PCUIF_Components.ttcn@508 
PS2, Line 508: start_fn := 0
What's the purpose of this variable? Why don't you just pass 0 directly, given that it's always 0?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00c4dd9133ec9a236bf28fb8cb0afd0615791012
Gerrit-Change-Number: 23324
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/a852de13/attachment.htm>


More information about the gerrit-log mailing list