Change in osmo-gsm-tester[master]: epc_amarisoft: launch ltesim server when starting

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 12 13:37:37 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342 )

Change subject: epc_amarisoft: launch ltesim server when starting
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342/1/src/osmo_gsm_tester/obj/epc_amarisoft.py 
File src/osmo_gsm_tester/obj/epc_amarisoft.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342/1/src/osmo_gsm_tester/obj/epc_amarisoft.py@122 
PS1, Line 122:         import time
I think it's fine importing time at the start of the module rather than here, it's a generic enough module with no extra dependencies.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342/1/src/osmo_gsm_tester/obj/epc_amarisoft.py@123 
PS1, Line 123:         time.sleep(2)
why do you need the sleep here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iad081e57e2fd9d3cbc3e59e4f729a4721ad778c9
Gerrit-Change-Number: 23342
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/3f9a88c7/attachment.htm>


More information about the gerrit-log mailing list