Change in pysim[master]: filesystem: be case insensitive when selecting files by fid (HEX)

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 12 07:35:39 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23205 )

Change subject: filesystem: be case insensitive when selecting files by fid (HEX)
......................................................................

filesystem: be case insensitive when selecting files by fid (HEX)

The file identifier (and allso application ids for ADFs), are
hexadecimal. We should be case insensitive when accepting hex
identifiers but file names should still be full matched.

Change-Id: Ibe283a108ddc9058af77c823b7222db555e1e0f6
Related: OS#4963
---
M pySim/filesystem.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index a9f2318..73401d6 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -580,6 +580,8 @@
     def select(self, name, cmd_app=None):
         """Change current directory"""
         sels = self.selected_file.get_selectables()
+        if is_hex(name):
+            name = name.lower()
         if name in sels:
             f = sels[name]
             # unregister commands of old file

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe283a108ddc9058af77c823b7222db555e1e0f6
Gerrit-Change-Number: 23205
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/2ce5d0bd/attachment.htm>


More information about the gerrit-log mailing list