Change in pysim[master]: pySim/utils_test.py: rename, move, and execute this on Jenkins

fixeria gerrit-no-reply at lists.osmocom.org
Thu Mar 11 22:21:41 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23327 )


Change subject: pySim/utils_test.py: rename, move, and execute this on Jenkins
......................................................................

pySim/utils_test.py: rename, move, and execute this on Jenkins

As it turns out, we had this set of unit tests since 2018, but
so far they were not executed during the build verification.

Let's fix this:

  * rename this file, so it can be automatically detected and executed;
  * run unittest in discovery mode for all files in 'tests/';
  * properly import the API to be tested.

Currently 2 out of 16 unit tests are failing.

Change-Id: I4d4facfabc75187acd5238ff4d0f26022bd58f82
---
M contrib/jenkins.sh
R tests/test_utils.py
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/23327/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index bfbf4e0..e286047 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -15,6 +15,9 @@
 pip install pyyaml
 pip install cmd2
 
+# Execute automatically discovered unit tests first
+python -m unittest discover -v -s tests/
+
 cd pysim-testdata
 ../tests/pysim-test.sh
 
diff --git a/pySim/utils_test.py b/tests/test_utils.py
similarity index 97%
rename from pySim/utils_test.py
rename to tests/test_utils.py
index 5cdb55e..44fe631 100644
--- a/pySim/utils_test.py
+++ b/tests/test_utils.py
@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 
 import unittest
-import utils 
+import pySim.utils as utils
 
 class DecTestCase(unittest.TestCase):
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23327
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4d4facfabc75187acd5238ff4d0f26022bd58f82
Gerrit-Change-Number: 23327
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/9902a725/attachment.htm>


More information about the gerrit-log mailing list