Change in osmo-bsc[master]: Add command to enable RX diversity to RBS2000

keith gerrit-no-reply at lists.osmocom.org
Thu Mar 11 20:05:01 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23318 )

Change subject: Add command to enable RX diversity to RBS2000
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23318/4/src/osmo-bsc/abis_om2000_vty.c@585 
PS4, Line 585: "Both\n"
> I see 'ab' in the middle of '(a|ab|b)', so this help string corresponds to 'b'. […]
Right. again.. hangover from the first draft. I had a,b,ab but then i think in an email the was a suggestion of a,ab,b.. which seems to make sense in a Left to Right kind of way. 

@javi Can you change the order of the help texts, compile and check it with the vty "?"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I430762b8cfa51060841d90ba4446de73bd557c6c
Gerrit-Change-Number: 23318
Gerrit-PatchSet: 4
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Thu, 11 Mar 2021 20:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/d6f9faa6/attachment.htm>


More information about the gerrit-log mailing list