Change in osmo-pcu[master]: Track TDMA clock with DATA.ind instead of TIME.ind

daniel gerrit-no-reply at lists.osmocom.org
Thu Mar 11 18:39:27 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23261 )

Change subject: Track TDMA clock with DATA.ind instead of TIME.ind
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23261/3/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23261/3/src/pcu_l1_if.cpp@810 
PS3, Line 810: 	 * providing all block FNs. */
Do we still want/need the log message above?
Otherwise we could get rid of the modulo/if and simply return 0



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23261
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibc495173119465e74f726ddc36e312334e6dc0fd
Gerrit-Change-Number: 23261
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Mar 2021 18:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/6afef29c/attachment.htm>


More information about the gerrit-log mailing list