Change in osmo-bts[master]: bts-trx: Always submit rx PDTCH DATA.ind to l1sap

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 11 17:41:46 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23257 )

Change subject: bts-trx: Always submit rx PDTCH DATA.ind to l1sap
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23257/4/src/osmo-bts-trx/sched_lchan_pdtch.c 
File src/osmo-bts-trx/sched_lchan_pdtch.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23257/4/src/osmo-bts-trx/sched_lchan_pdtch.c@148 
PS4, Line 148: presence_info
> I think you could just do: […]
That means yet another comparison/branching which is not needed since we already do that above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23257
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I343c7a721dab72411edbca816c8864926bc329fb
Gerrit-Change-Number: 23257
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Mar 2021 17:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/11689925/attachment.htm>


More information about the gerrit-log mailing list