Change in docker-playground[master]: Make respawn.sh a common part of *-build/-obs images

osmith gerrit-no-reply at lists.osmocom.org
Wed Mar 10 15:09:46 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23303 )

Change subject: Make respawn.sh a common part of *-build/-obs images
......................................................................


Patch Set 3:

> Why would we need to bisect changes in respawn.sh?

Not in the script in particular, but maybe we need to bisect the whole docker-playground.git. I've done this before once. Even if that is not used very often, if we have the choice to break it or not, I'd rather not break it.

> Ah, I see at least one disadvantage now: one won't be able to make changes to respawn.sh / Release.key and test them locally. It will be required to merge the patch first, or hack Dockerfiles to COPY the changed file from the current directory...

Yes, that's another good argument.


-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e
Gerrit-Change-Number: 23303
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Mar 2021 15:09:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/1a9ca59c/attachment.htm>


More information about the gerrit-log mailing list