Change in osmo-sgsn[master]: manuals: Regenerate counters/VTY through docker

daniel gerrit-no-reply at lists.osmocom.org
Wed Mar 10 13:12:10 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23305 )

Change subject: manuals: Regenerate counters/VTY through docker
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I'm missing some kind of rationale. Is this what other osmo-* projects do?  Why is docker needed here? ...

Yeah, every other project uses it:
$ find . -name regen_doc.sh -exec grep -l DOCKER_PLAYGROUND {} \;
./osmo-ggsn/doc/manuals/regen_doc.sh
./osmo-bts/doc/manuals/regen_doc.sh
./osmo-pcu/doc/manuals/regen_doc.sh
./osmo-mgw/doc/manuals/regen_doc.sh
./osmo-msc/doc/manuals/regen_doc.sh
./osmo-bsc/doc/manuals/regen_doc.sh
./osmo-cbc/doc/manuals/regen_doc.sh
./osmo-sgsn/doc/manuals/regen_doc.sh
./osmo-gbproxy/doc/manuals/regen_doc.sh
./osmo-hlr/doc/manuals/regen_doc.sh

The issue the current script has is that it uses whatever osmo-sgsn is in you path, so the version will most likely mismatch (and it will fail if the version found in path can not read the config file from examples).

What I can't explain is why simply calling ../../src/osmo-sgsn in regen_doc.sh won't work as well as using docker.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I09b01d2e4bc7b1c17588100b16ac9f04cf72cf99
Gerrit-Change-Number: 23305
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 10 Mar 2021 13:12:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/3fa62d25/attachment.htm>


More information about the gerrit-log mailing list