Change in osmo-gbproxy[master]: Remove some outdated TODO/comments

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 10 12:10:42 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23306 )

Change subject: Remove some outdated TODO/comments
......................................................................

Remove some outdated TODO/comments

Change-Id: Icd72ed92585f5701d293807022255b06e5641005
---
M include/osmocom/sgsn/gb_proxy.h
M src/gb_proxy.c
2 files changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/include/osmocom/sgsn/gb_proxy.h b/include/osmocom/sgsn/gb_proxy.h
index c9d2fca..2a800e5 100644
--- a/include/osmocom/sgsn/gb_proxy.h
+++ b/include/osmocom/sgsn/gb_proxy.h
@@ -165,7 +165,7 @@
 	/* NSEI of the NSE */
 	uint16_t nsei;
 
-	/* Maximum side of the NS-UNITDATA NS SDU that can be transported by the NSE */
+	/* Maximum size of the NS-UNITDATA NS SDU that can be transported by the NSE */
 	uint16_t max_sdu_len;
 
 	/* Are we facing towards a SGSN (true) or BSS (false) */
diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index 78e1e1d..4890981 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -1128,8 +1128,6 @@
 	int errctr = GBPROX_GLOB_CTR_PROTO_ERR_SGSN;
 	int i, j;
 
-	/* FIXME: Handle paging logic to only page each matching NSE */
-
 	if (TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2)) {
 		uint16_t bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
 		errctr = GBPROX_GLOB_CTR_OTHER_ERR;
@@ -1514,8 +1512,6 @@
 /*  TODO: What about handling:
  * 	GPRS_NS2_AFF_CAUSE_VC_FAILURE,
 	GPRS_NS2_AFF_CAUSE_VC_RECOVERY,
-	GPRS_NS2_AFF_CAUSE_FAILURE,
-	GPRS_NS2_AFF_CAUSE_RECOVERY,
 	osmocom own causes
 	GPRS_NS2_AFF_CAUSE_SNS_CONFIGURED,
 	GPRS_NS2_AFF_CAUSE_SNS_FAILURE,
@@ -1524,8 +1520,6 @@
 void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct osmo_gprs_ns2_prim *nsp)
 {
 	/* TODO: bss nsei available/unavailable  bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_BLOCK, nsvc->nsei, bvc->bvci, 0);
-	 * TODO: sgsn nsei available/unavailable
-	 * TODO: Update MTU
 	 */
 
 	struct gbproxy_bvc *bvc;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/23306
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Icd72ed92585f5701d293807022255b06e5641005
Gerrit-Change-Number: 23306
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/28ab2338/attachment.htm>


More information about the gerrit-log mailing list