Change in docker-playground[master]: Make respawn.sh a common part of *-build/-obs images

osmith gerrit-no-reply at lists.osmocom.org
Wed Mar 10 10:05:06 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23303 )

Change subject: Make respawn.sh a common part of *-build/-obs images
......................................................................


Patch Set 3: Verified-1

If we download the file from https://git.osmocom.org/, we can't bisect changes in the file, it will always use the latest copy from master.

I suggest we change make/Makefile (which is used to build all containers) and add this in the "pre-build" target:
  rm -rf .common
  cp -r ../common .

Then add .common to gitignore, and add the file from .common to the *-build/Dockerfile and *-obs-latest/Dockerfile instead of downloading it from git.osmocom.org.

(Idea untested)


-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3ec86c8610b3b43d39ea8e3da444861d317ced4e
Gerrit-Change-Number: 23303
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Mar 2021 10:05:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/2b7d6ab5/attachment.htm>


More information about the gerrit-log mailing list