Change in osmo-pcu[master]: Improve logging in DATA.req and ACT.req

pespin gerrit-no-reply at lists.osmocom.org
Tue Mar 9 18:21:43 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23290 )

Change subject: Improve logging in DATA.req and ACT.req
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23290/1/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23290/1/src/pcu_l1_if.cpp@181 
PS1, Line 181: bts=%u,trx=%u,ts=%u
> Finally no ugly PRIuN! \o/
I still think PRIu% would be better but I'm changing so much stuff and in the process of rewriting the UL scheduler that I went for the quickest way here to have better output I can use later for debugging.


https://gerrit.osmocom.org/c/osmo-pcu/+/23290/1/src/pcu_l1_if.cpp@482 
PS1, Line 482: LOGP
> Why not LOGPDCH?
Because it's clearly not a PDCH, since it's not SAPI PDTCH nor PTCCH.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id57d50d8bf528adfef3713c594102d31ab49c149
Gerrit-Change-Number: 23290
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Mar 2021 18:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210309/82c293ec/attachment.htm>


More information about the gerrit-log mailing list