This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23167 )
Change subject: stats: Ensure that each osmo_stat_item only reports once per interval
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/c/libosmocore/+/23167/1/src/stats.c
File src/stats.c:
https://gerrit.osmocom.org/c/libosmocore/+/23167/1/src/stats.c@708
PS1, Line 708: //
> comment style
Done
https://gerrit.osmocom.org/c/libosmocore/+/23167/1/src/stats.c@709
PS1, Line 709: do {
> It could be a regular while() loop, I see no need for do { ... } while (...): […]
Thanks, that looks much nicer
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23167
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I366ab1c66f4ae6363111ea4e41b66b7d5bcade9c
Gerrit-Change-Number: 23167
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Mar 2021 13:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210309/77cdff4d/attachment.htm>