Change in osmo-pcu[master]: Introduce init() APIs for PDCH and TRX objects

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 8 17:08:37 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23269 )

Change subject: Introduce init() APIs for PDCH and TRX objects
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23269/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23269/1/src/pdch.cpp@a1043 
PS1, Line 1043: init_ptcch_msg
> I don't see a reason for moving this API. […]
Sure I could do so, but what's the point? It doesn't have any specific code path, it's simply more stuff which needs to be initialized at the same place, so it's a lot clearer merging them in one init function.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Idf1dbdf8bc0b1e16d86eeeffb1193fdf3a57d6ef
Gerrit-Change-Number: 23269
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Mar 2021 17:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210308/9a13191a/attachment.htm>


More information about the gerrit-log mailing list