Change in osmo-bsc[master]: stats: add BTS uptime counter
gerrit-no-reply at lists.osmocom.org
Mon Mar 8 11:51:02 UTC 2021
iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23234 )
Change subject: stats: add BTS uptime counter
Patch Set 2:
> What exactly are you trying to achieve here? what is uptime?
I am considering uptime to mean the same as you've already defined it in the VTY output: the BSC and BTS have had a valid connection.
But instead of delivering this information via the VTY, I want to export it via the statsd reporter. The ultimate goal is to be able to tell from the gathered statsd data: how many seconds of downtime did we experience in a given time interval.
Counting downtime is also a possibility but OsmoBSC already contained the concept of uptime so I've used it.
This patch samples the change in uptime every X seconds and adds it to the uptime counter. This only needs to happen once per statsd reporter interval so a callback from that action might be better...or simply a way to know the current statsd reporter interval.
> In any case, none of the above is a rate counter. Rate counters count the rate of events, such as the rate of BTS re-starts, the rate of channel allocations, etc.
> something like a stat_item might be better suited?
I don't know enough about the stats system I guess to make that call. I just want to store the number of seconds of uptime per interval. Just as we count "channel activations per interval" I thought this was the way to go. Is a stat_item a more logical fit? I'll gladly refactor to use it if so.
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Mar 2021 11:51:02 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log