Change in osmo-gsm-tester[master]: Fix bts.ready_for_pcu() implementation for sysmo and oc2g

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 8 11:15:40 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23267 )

Change subject: Fix bts.ready_for_pcu() implementation for sysmo and oc2g
......................................................................

Fix bts.ready_for_pcu() implementation for sysmo and oc2g

osmo-bts.git ae09c8acb4aa93284cdb44f8bbdc14533dc4fa52 modified code to
avoid calling pcu_tx_info_ind() if pcu socket was not connected. Since
osmo-gsm-tester relied on log message sent from within that funtion to
find out whether BTS was able to handle PCUIF connections, that log line
is not printed anymore and hence the function ready_for_pcu() fails to
ever return true.
As a result, gprs tests for sysmo and oc2g bts types always fail with a
timeout.

Other BTS types are not affected (such as osmo-bts-trx) because in there
we simply check whether the osmo-bts process is running.

Change-Id: Ibde4b8b27b8300b4b9197c0f8d82a6ccbf3b0522
---
M src/osmo_gsm_tester/obj/bts_oc2g.py
M src/osmo_gsm_tester/obj/bts_sysmo.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/obj/bts_oc2g.py b/src/osmo_gsm_tester/obj/bts_oc2g.py
index 7761ce3..9164827 100644
--- a/src/osmo_gsm_tester/obj/bts_oc2g.py
+++ b/src/osmo_gsm_tester/obj/bts_oc2g.py
@@ -88,7 +88,7 @@
     def ready_for_pcu(self):
         if not self.proc_bts or not self.proc_bts.is_running:
             return False
-        return 'BTS is up' in (self.proc_bts.get_stdout() or '')
+        return 'Started listening on PCU socket' in (self.proc_bts.get_stdout() or '')
 
     def start(self, keepalive=False):
         if self.bsc is None:
diff --git a/src/osmo_gsm_tester/obj/bts_sysmo.py b/src/osmo_gsm_tester/obj/bts_sysmo.py
index 3f48f93..91a46be 100644
--- a/src/osmo_gsm_tester/obj/bts_sysmo.py
+++ b/src/osmo_gsm_tester/obj/bts_sysmo.py
@@ -88,7 +88,7 @@
     def ready_for_pcu(self):
         if not self.proc_bts or not self.proc_bts.is_running:
             return False
-        return 'BTS is up' in (self.proc_bts.get_stdout() or '')
+        return 'Started listening on PCU socket' in (self.proc_bts.get_stdout() or '')
 
     def start(self, keepalive=False):
         if self.bsc is None:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ibde4b8b27b8300b4b9197c0f8d82a6ccbf3b0522
Gerrit-Change-Number: 23267
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210308/b85a1120/attachment.htm>


More information about the gerrit-log mailing list