Change in libosmocore[master]: gprs_ns2_vty: Clarify VTY help string wording

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 6 08:15:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23243 )

Change subject: gprs_ns2_vty: Clarify VTY help string wording
......................................................................

gprs_ns2_vty: Clarify VTY help string wording

Change-Id: I7d70f8cc811c2f4aabf9fc00e4e612dfc4b031d3
---
M src/gb/gprs_ns2_vty.c
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 6214907..76e4434 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -352,9 +352,9 @@
 /* TODO: add fr/gre */
 DEFUN(cfg_ns_bind, cfg_ns_bind_cmd,
       "bind (fr|udp) ID",
-      "Binding\n"
+      "Configure local Bind\n"
       "Frame Relay\n" "UDP/IP\n"
-      "a unique identifier for this bind to reference NS-VCs\n"
+      "Unique identifier for this bind (to reference from NS-VCs, NSEs, ...)\n"
       )
 {
 	const char *nstype = argv[0];
@@ -398,8 +398,8 @@
 DEFUN(cfg_no_ns_bind, cfg_no_ns_bind_cmd,
       "no bind ID",
       NO_STR
-      "Delete a binding\n"
-      "a unique identifier for this bind to reference NS-VCs\n"
+      "Delete a bind\n"
+      "Unique identifier for this bind\n"
       )
 {
 	struct vty_bind *vbind;
@@ -599,9 +599,9 @@
 
 DEFUN(cfg_ns_bind_listen, cfg_ns_bind_listen_cmd,
       "listen " VTY_IPV46_CMD " <1-65535>",
-      "Binding\n"
-      "IPv4 Address\n" "IPv6 Address\n"
-      "Port\n"
+      "Configure local IP + Port of this bind\n"
+      "Local IPv4 Address\n" "Local IPv6 Address\n"
+      "Local UDP Port\n"
       )
 {
 	struct vty_bind *vbind = vty->index;
@@ -1540,7 +1540,7 @@
 DEFUN(cfg_ns_nse_ip_sns_bind, cfg_ns_nse_ip_sns_bind_cmd,
       "ip-sns-bind BINDID",
       "IP SNS binds\n"
-      "A udp bind which this SNS will be used. The bind must be already exists. Can be given multiple times.\n")
+      "Name of NS udp bind whose IP endpoint will be used as IP-SNS local endpoint. Can be given multiple times.\n")
 {
 	struct gprs_ns2_nse *nse = vty->index;
 	struct gprs_ns2_vc_bind *bind;
@@ -1641,7 +1641,7 @@
       "no ip-sns-bind BINDID",
       NO_STR
       "IP SNS binds\n"
-      "A udp bind which this SNS will be used.\n")
+      "Name of NS udp bind whose IP endpoint will not be used as IP-SNS local endpoint\n")
 {
 	struct gprs_ns2_nse *nse = vty->index;
 	struct gprs_ns2_vc_bind *bind;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7d70f8cc811c2f4aabf9fc00e4e612dfc4b031d3
Gerrit-Change-Number: 23243
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210306/5943a0ac/attachment.htm>


More information about the gerrit-log mailing list