Change in libosmocore[master]: gprs_ns2_sns: Remove TODO (spec agrees, the correct cause code is used)

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 6 08:15:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23242 )

Change subject: gprs_ns2_sns: Remove TODO (spec agrees, the correct cause code is used)
......................................................................

gprs_ns2_sns: Remove TODO (spec agrees, the correct cause code is used)

Change-Id: I6c431ba9e30d19425bf1cc1cc4d081949058610b
---
M src/gb/gprs_ns2_sns.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 715dd8e..04cebf4 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -446,7 +446,6 @@
 		if (memcmp(&gss->ip4_remote[i], ip4, sizeof(*ip4)))
 			continue;
 		/* TODO: log message duplicate */
-		/* TODO: check if this is the correct cause code */
 		return -NS_CAUSE_PROTO_ERR_UNSPEC;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23242
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c431ba9e30d19425bf1cc1cc4d081949058610b
Gerrit-Change-Number: 23242
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210306/16f83661/attachment.htm>


More information about the gerrit-log mailing list