Change in osmo-pcu[master]: tbf: Log N310* counter increments

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 5 20:40:47 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23233 )

Change subject: tbf: Log N310* counter increments
......................................................................

tbf: Log N310* counter increments

Change-Id: Iacd2fb894b4f2a9aade7e66aa40969fea031c3b2
---
M src/tbf.cpp
M tests/tbf/TbfTest.err
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/tbf.cpp b/src/tbf.cpp
index 5ca34f4..15d3fa1 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -414,9 +414,11 @@
 		LOGPTBF(this, LOGL_NOTICE, "%s exceeded MAX (%u)\n",
 			get_value_string(tbf_counters_names, n), chk);
 		return true;
+	} else {
+		LOGPTBF(this, LOGL_DEBUG, "%s %" PRIu8 " => %" PRIu8 " (< MAX %" PRIu8 ")\n",
+			get_value_string(tbf_counters_names, n), Narr[n] - 1, Narr[n], chk);
+		return false;
 	}
-
-	return false;
 }
 
 void gprs_rlcmac_tbf::t_stop(enum tbf_timers t, const char *reason)
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 685f9d0..5a8b5bb 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -1721,7 +1721,9 @@
 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7
 Found first unallocated TRX=0 TFI=1
 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) poll timeout for FN=2654292, TS=7 (curr FN 2654335)
+TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) N3101 0 => 1 (< MAX 10)
 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) Timeout for polling PACKET DOWNLINK ACK: |Assignment was on PACCH|No downlink ACK received yet|
+TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) N3105 0 => 1 (< MAX 8)
 PDCH(bts=0,trx=0,ts=7) +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) ------------------------- RX : Uplink Control Block -------------------------
 Creating MS object, TLLI = 0xffffffff

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23233
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iacd2fb894b4f2a9aade7e66aa40969fea031c3b2
Gerrit-Change-Number: 23233
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210305/73de246e/attachment.htm>


More information about the gerrit-log mailing list