Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to validate X2301 and T3191

osmith gerrit-no-reply at lists.osmocom.org
Fri Mar 5 13:12:05 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23200 )

Change subject: pcu: Introduce tests to validate X2301 and T3191
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23200/3/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23200/3/pcu/PCU_Tests.ttcn@1353 
PS3, Line 1353: 	while (true) {
Maybe add a ttcn-3 timer that stops the test if it takes too long? Then the test won't run forever here if osmo-pcu doesn't behave as expected.

Same for the while (true) below.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23200/3/pcu/PCU_Tests.ttcn@1401 
PS3, Line 1401: requestinb
(requesting, also below)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23200
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib6dfc5711b9c6f1fd404bce424bbf4b115fc930e
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Mar 2021 13:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210305/74389e99/attachment.htm>


More information about the gerrit-log mailing list