Change in libosmocore[master]: gprs_ns2_sns: Unify handling of SNS-CONFIG for IPv4 + IPv6

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 5 10:30:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23245 )

Change subject: gprs_ns2_sns: Unify handling of SNS-CONFIG for IPv4 + IPv6
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/23245/2/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/23245/2/src/gb/gprs_ns2_sns.c@954 
PS2, Line 954: 						 gss->num_ip4_remote+num_v4);
space in "+" (I know it was already like that, but it's incredibly annoying to read otherwise)


https://gerrit.osmocom.org/c/libosmocore/+/23245/2/src/gb/gprs_ns2_sns.c@975 
PS2, Line 975: 						 gss->num_ip6_remote+num_v6);
same



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23245
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I49e5ca4a09bc772ef5a0cd5c2a76c8b200e56d1b
Gerrit-Change-Number: 23245
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Mar 2021 10:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210305/17dfbea8/attachment.htm>


More information about the gerrit-log mailing list