Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_n3105_max_t3195

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 4 20:12:57 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23215 )

Change subject: pcu: Introduce test TC_n3105_max_t3195
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23215/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23215/1/pcu/PCU_Tests.ttcn@1619 
PS1, Line 1619: 		nr := ts_TsTrxBtsNum;
> This variable is already set above, why do you re-initialize it here and below? Does it change?
It doesn't change now, but I prefer leaving it there in case we want to improve infrastructure to do something like f_ms_tr_TsTrxBtsNum(ms) which would return tn to be any of the TNs with a USF set.
Not really needed here since we use 1 TS, but still easier to understand imho that in theory nr should be updated here in general.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23215
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6f756c928509364fee14c552279f01b4e4f0e060
Gerrit-Change-Number: 23215
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Mar 2021 20:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210304/cd3c3b9e/attachment.htm>


More information about the gerrit-log mailing list