This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23223 ) Change subject: gprs_ns2_sns: Dispatch inbound SNS-ACK to FSM ...................................................................... gprs_ns2_sns: Dispatch inbound SNS-ACK to FSM We don't really handle inbound SNS-ACK yet (as we don't originate SNS ADD/DEL/CHGWEIGHT procedures yet). However, the message receive code should already dispatch those events to the FSM, just like we do for the (equally unimplemented) handling of inbound SNS-SIZE which is already dispatched to the FSM. Change-Id: If6d5f96d85e6f05534fe49376f4473d912535ad4 --- M src/gb/gprs_ns2_sns.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index 698f60a..0bb7422 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -79,6 +79,7 @@ GPRS_SNS_EV_RX_ADD, GPRS_SNS_EV_RX_DELETE, GPRS_SNS_EV_RX_CHANGE_WEIGHT, + GPRS_SNS_EV_RX_ACK, /*!< Rx of SNS-ACK (response to ADD/DELETE/CHG_WEIGHT */ GPRS_SNS_EV_REQ_NO_NSVC, /*!< no more NS-VC remaining (all dead) */ GPRS_SNS_EV_REQ_NSVC_ALIVE, /*!< a NS-VC became alive */ GPRS_SNS_EV_REQ_ADD_BIND, /*!< add a new local bind to this NSE */ @@ -94,6 +95,7 @@ { GPRS_SNS_EV_RX_CONFIG_ACK, "RX_CONFIG_ACK" }, { GPRS_SNS_EV_RX_ADD, "RX_ADD" }, { GPRS_SNS_EV_RX_DELETE, "RX_DELETE" }, + { GPRS_SNS_EV_RX_ACK, "RX_ACK" }, { GPRS_SNS_EV_RX_CHANGE_WEIGHT, "RX_CHANGE_WEIGHT" }, { GPRS_SNS_EV_REQ_NO_NSVC, "REQ_NO_NSVC" }, { GPRS_SNS_EV_REQ_NSVC_ALIVE, "REQ_NSVC_ALIVE"}, @@ -1599,8 +1601,7 @@ osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_RX_CHANGE_WEIGHT, tp); break; case SNS_PDUT_ACK: - LOGPFSML(fi, LOGL_NOTICE, "NSEI=%u Rx unsupported SNS PDU type %s\n", nsei, - get_value_string(gprs_ns_pdu_strings, nsh->pdu_type)); + osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_RX_ACK, tp); break; default: LOGPFSML(fi, LOGL_ERROR, "NSEI=%u Rx unknown SNS PDU type %s\n", nsei, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If6d5f96d85e6f05534fe49376f4473d912535ad4 Gerrit-Change-Number: 23223 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210304/7a4ea15f/attachment.htm>