Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_no_ack_retrans_imm_ass

fixeria gerrit-no-reply at lists.osmocom.org
Wed Mar 3 18:14:29 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23199 )

Change subject: pcu: Introduce test TC_dl_no_ack_retrans_imm_ass
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23199/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23199/2/pcu/PCU_Tests.ttcn@2152 
PS2, Line 2152: 	//info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));
Any reason to keep commented out lines?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23199/2/pcu/PCU_Tests.ttcn@2196 
PS2, Line 2196: done
What if you get a dummy block after the first RTS.req?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23199
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1c1d89f3de9ba158f802e7759ef78dc84f48218f
Gerrit-Change-Number: 23199
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Mar 2021 18:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/28077a25/attachment.htm>


More information about the gerrit-log mailing list