Change in pysim[master]: ts_102_221: fix fixup_fcp_proprietary_tlv_map()

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 08:27:59 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23211 )

Change subject: ts_102_221: fix fixup_fcp_proprietary_tlv_map()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/23211/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/pysim/+/23211/1//COMMIT_MSG@13 
PS1, Line 13: This makes no sense
well, it follows the spec which states that D0 and onwards are reserved for proprietary tags ;)


https://gerrit.osmocom.org/c/pysim/+/23211/1//COMMIT_MSG@15 
PS1, Line 15: t
I think the real solution here is to move away from pytlv, rather than adding moer and more hacks to twist it to what we need.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23211
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib06041361851f05dd990576fff47048dc1aa6290
Gerrit-Change-Number: 23211
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/9adc6ceb/attachment.htm>


More information about the gerrit-log mailing list