Change in pysim[master]: pySim-shell: add filesystem exporter

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 08:26:19 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23210 )

Change subject: pySim-shell: add filesystem exporter
......................................................................


Patch Set 1:

(1 comment)

I don't see code that would generate "select" commands?

https://gerrit.osmocom.org/c/pysim/+/23210/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23210/1/pySim-shell.py@167 
PS1, Line 167: print
we should use poutput rather than print, IMHO? (also below for the update_record).



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I82f3ce92cd91a5ed3c4884d62f6b22e9589c8a49
Gerrit-Change-Number: 23210
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/7ebeffcd/attachment.htm>


More information about the gerrit-log mailing list