Change in pysim[master]: filesystem: decode select response for MF

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 08:23:57 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23209 )

Change subject: filesystem: decode select response for MF
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

the problem here is whether it is 'legal' to make such an assumption.  Afte

https://gerrit.osmocom.org/c/pysim/+/23209/1/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/23209/1/pySim/filesystem.py@247 
PS1, Line 247:       
are we sure this is the right thing to do?  Which spec states that the root of any card will provide SELECT responses in-line with the old SIM specs?

I would argue that on an UICC (i.e. USIM, ISIM, ...) this is actually wrong, as it always will use ETS 102 221 (UICC) - maybe _unless_ you start using old GSM command with CLA=A0.

Which card did you test? Were the results conclusive?

I think this definitely would have to be configurable, i.e. the card pfofile should have control over this, and not hard-coded in the filesystem.py module.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib2b2476fc0e7d34cdacf7eb100ffadceb788c4d2
Gerrit-Change-Number: 23209
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/67514c00/attachment.htm>


More information about the gerrit-log mailing list