Change in osmo-pcu[master]: tbd_dl: Don't re-initialize class field twice

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 07:29:51 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23195 )

Change subject: tbd_dl: Don't re-initialize class field twice
......................................................................

tbd_dl: Don't re-initialize class field twice

Change-Id: Ia92c24032dc1f8965008ff03a3a0a94bbb93893a
---
M src/tbf_dl.cpp
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 57044a1..88bab7d 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -171,9 +171,6 @@
 	llist_add(tbf_bts_list((struct gprs_rlcmac_tbf *)tbf), &bts->dl_tbfs);
 	bts_do_rate_ctr_inc(tbf->bts, CTR_TBF_DL_ALLOCATED);
 
-	tbf->m_last_dl_poll_fn = -1;
-	tbf->m_last_dl_drained_fn = -1;
-
 	osmo_clock_gettime(CLOCK_MONOTONIC, &tbf->m_bw.dl_bw_tv);
 	osmo_clock_gettime(CLOCK_MONOTONIC, &tbf->m_bw.dl_loss_tv);
 
@@ -185,8 +182,8 @@
 	m_tx_counter(0),
 	m_wait_confirm(0),
 	m_dl_ack_requested(false),
-	m_last_dl_poll_fn(0),
-	m_last_dl_drained_fn(0),
+	m_last_dl_poll_fn(-1),
+	m_last_dl_drained_fn(-1),
 	m_dl_gprs_ctrs(NULL),
 	m_dl_egprs_ctrs(NULL)
 {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia92c24032dc1f8965008ff03a3a0a94bbb93893a
Gerrit-Change-Number: 23195
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/8d92c19c/attachment.htm>


More information about the gerrit-log mailing list