Change in libosmocore[master]: gprs_ns2: sns: move alive timeout into own variable

pespin gerrit-no-reply at lists.osmocom.org
Tue Mar 2 10:21:48 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23185 )

Change subject: gprs_ns2: sns: move alive timeout into own variable
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23185/1/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/23185/1/src/gb/gprs_ns2_sns.c@964 
PS1, Line 964: 		osmo_timer_schedule(&gss->alive_timeout, ns_sns_configured_timeout(fi), 0);
may it make more sense to put it on on_enter() of st configured?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4b223118c7f250dbc8161cbf29cbd994c26c362f
Gerrit-Change-Number: 23185
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Mar 2021 10:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210302/451be255/attachment.htm>


More information about the gerrit-log mailing list