Change in osmo-bts[master]: sched_lchan_tchh: fix frame number and fill FACCH gap

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 20:28:27 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21329 )

Change subject: sched_lchan_tchh: fix frame number and fill FACCH gap
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 3:
> > 
> > Let's keep it WIP for now, I will work on this patch once I have time.
> 
> The patch is not WIP, at least not in the sense of the gerrit status.

I cannot make it WIP because I am not the author.

> AFAICT, the patch claims to fix a real problem, and while you may have some valid criticism, we cannot ignore bugfixes for more amount of time until "you have time".  Please let me know if you think your concerns warrant keeping this out of mainline any longer.

I cannot commit any deadline as I am currently busy working on a big customer's task, and there is still a lot to be done. My criticism still applies and I am against merging it as-is. But if you find the current approach acceptable and it solves the problem, then do not wait for me.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9fa3815feb2b4da608ab7df716a87ba1f2f91
Gerrit-Change-Number: 21329
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 01 Mar 2021 20:28:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/38431405/attachment.htm>


More information about the gerrit-log mailing list