Change in osmocom-bb[master]: trx_toolkit/data_msg.py: decorate abstract methods as such

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 15:02:38 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23131 )

Change subject: trx_toolkit/data_msg.py: decorate abstract methods as such
......................................................................

trx_toolkit/data_msg.py: decorate abstract methods as such

Change-Id: I27fdcfdabc2b5318ab3e958d2e5446e670fe9035
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/data_msg.py
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py
index 89fb916..cafe7a6 100644
--- a/src/target/trx_toolkit/data_msg.py
+++ b/src/target/trx_toolkit/data_msg.py
@@ -23,6 +23,7 @@
 
 import random
 import struct
+import abc
 
 from enum import Enum
 from gsm_shared import *
@@ -55,7 +56,7 @@
 				return mod
 		return None
 
-class DATAMSG:
+class DATAMSG(abc.ABC):
 	""" TRXD (DATA) message codec (common part).
 
 	The DATA messages are used to carry bursts in both directions
@@ -133,25 +134,25 @@
 		''' The common header length. '''
 		return 1 + 4 # (VER + TN) + FN
 
+	@abc.abstractmethod
 	def gen_hdr(self):
 		''' Generate message specific header. '''
-		raise NotImplementedError
 
+	@abc.abstractmethod
 	def parse_hdr(self, hdr):
 		''' Parse message specific header. '''
-		raise NotImplementedError
 
+	@abc.abstractmethod
 	def gen_burst(self):
 		''' Generate message specific burst. '''
-		raise NotImplementedError
 
+	@abc.abstractmethod
 	def parse_burst(self, burst):
 		''' Parse message specific burst. '''
-		raise NotImplementedError
 
+	@abc.abstractmethod
 	def rand_burst(self):
 		''' Generate a random message specific burst. '''
-		raise NotImplementedError
 
 	def rand_fn(self):
 		''' Generate a random frame number. '''

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I27fdcfdabc2b5318ab3e958d2e5446e670fe9035
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/b80dba75/attachment.htm>


More information about the gerrit-log mailing list