Change in osmocom-bb[master]: trx_toolkit/data_msg.py: do not instantiate abstract class DATAMSG

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 15:02:35 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23148 )

Change subject: trx_toolkit/data_msg.py: do not instantiate abstract class DATAMSG
......................................................................

trx_toolkit/data_msg.py: do not instantiate abstract class DATAMSG

Change-Id: I811f67ae030ccd93e1c6a421097cec36ca01cbf9
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/test_data_msg.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/target/trx_toolkit/test_data_msg.py b/src/target/trx_toolkit/test_data_msg.py
index 6254203..8735b0c 100644
--- a/src/target/trx_toolkit/test_data_msg.py
+++ b/src/target/trx_toolkit/test_data_msg.py
@@ -62,23 +62,23 @@
 	def test_validate(self):
 		# Unknown version
 		with self.assertRaises(ValueError):
-			msg = DATAMSG(fn = 0, tn = 0, ver = 100)
+			msg = DATAMSG_TRX2L1(fn = 0, tn = 0, ver = 100)
 			msg.validate()
 
 		# Uninitialized field
 		with self.assertRaises(ValueError):
-			msg = DATAMSG()
+			msg = DATAMSG_TRX2L1()
 			msg.validate()
 		with self.assertRaises(ValueError):
-			msg = DATAMSG(fn = None, tn = 0)
+			msg = DATAMSG_TRX2L1(fn = None, tn = 0)
 			msg.validate()
 
 		# Out-of-range value(s)
 		with self.assertRaises(ValueError):
-			msg = DATAMSG(fn = -1, tn = 0)
+			msg = DATAMSG_TRX2L1(fn = -1, tn = 0)
 			msg.validate()
 		with self.assertRaises(ValueError):
-			msg = DATAMSG(fn = 0, tn = 10)
+			msg = DATAMSG_TRX2L1(fn = 0, tn = 10)
 			msg.validate()
 
 	# Validate header and burst randomization

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23148
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I811f67ae030ccd93e1c6a421097cec36ca01cbf9
Gerrit-Change-Number: 23148
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/5781f5f0/attachment.htm>


More information about the gerrit-log mailing list