Change in osmocom-bb[master]: trx_toolkit/data_msg.py: decorate abstract methods as such

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 14:51:40 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23131 )

Change subject: trx_toolkit/data_msg.py: decorate abstract methods as such
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/23131/2/src/target/trx_toolkit/data_msg.py 
File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/23131/2/src/target/trx_toolkit/data_msg.py@160 
PS2, Line 160: 		raise NotImplementedError
> fyi, since they are marked abstractmethod they shouldn't be callable because python wil ldetec tit a […]
ACK, removed in the new patch set.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I27fdcfdabc2b5318ab3e958d2e5446e670fe9035
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Mar 2021 14:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/ea6fb9dc/attachment.htm>


More information about the gerrit-log mailing list