Change in osmocom-bb[master]: trx_toolkit: check in simple declarative codec

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 13:47:54 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23135 )

Change subject: trx_toolkit: check in simple declarative codec
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> Not sure if this is really performant, but will see.

It's not gonna be faster than the current implementation, but will definitely be faster than Scapy or Pycrate. I find declarative approach easier to maintain when it comes to different TRXD versions, especially TRXDv2 with batching and completely different field ordering.


-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23135
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7ff46b278c59af3720ee7f3950ea5a8b2f1313e1
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Mar 2021 13:47:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/da660f57/attachment.htm>


More information about the gerrit-log mailing list