Change in osmo-ci[master]: OBS: latest: run osmo_obs_add_rpm_spec every time

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 1 12:52:40 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/23156 )

Change subject: OBS: latest: run osmo_obs_add_rpm_spec every time
......................................................................

OBS: latest: run osmo_obs_add_rpm_spec every time

Replace the current logic, that would only run osmo_obs_add_rpm_spec
when adding a new package, or when the version of a package has changed,
with running it every time.

Running the command when it is not needed does not hurt, as it does not
take significant time, and osc does not attempt to upload the file when
it did not change.

The advantage is, that we can update/upload the spec file without
tagging a new version, if a bug prevented it from getting uploaded
before (as it just was the case for all Osmocom packages).

Related: OS#5054
Change-Id: Ie067c97b5f54ec5b3309ddbd2bfb7f846cd0ccd3
---
M scripts/osmocom-latest-packages.sh
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified
  pespin: Looks good to me, but someone else must approve



diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh
index 9bf08eb..fddcf0c 100755
--- a/scripts/osmocom-latest-packages.sh
+++ b/scripts/osmocom-latest-packages.sh
@@ -96,7 +96,6 @@
     mv "$output/"*.tar* "$TOP/$PROJ/$project/"
     cd "$TOP/$PROJ"
     osc add "$project"
-    osmo_obs_add_rpm_spec "$TOP/$PROJ/$project" "$TOP/$project" "$project" "osmocom-latest"
   else
     cd "$TOP/$PROJ/$project"
 
@@ -107,9 +106,11 @@
       mv "$output/"*.dsc .
       mv "$output/"*.tar* .
       osc add ./*
-      osmo_obs_add_rpm_spec "$PWD" "$TOP/$project" "$project" "osmocom-latest"
     fi
   fi
+
+  osmo_obs_add_rpm_spec "$TOP/$PROJ/$project" "$TOP/$project" "$project" "osmocom-latest"
+
   cd "$TOP"
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/23156
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie067c97b5f54ec5b3309ddbd2bfb7f846cd0ccd3
Gerrit-Change-Number: 23156
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/8f212bf4/attachment.htm>


More information about the gerrit-log mailing list