Change in pysim[master]: cards: rename class "Card" to "SimCard"

laforge gerrit-no-reply at lists.osmocom.org
Wed Jun 30 08:17:12 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24142 )

Change subject: cards: rename class "Card" to "SimCard"
......................................................................

cards: rename class "Card" to "SimCard"

There are the classes IsimCard and UsimCard, which inheret from Card,
which is the base class for a normal non ISIM/USIM simcard. Card also
has methods in it that are related to simcards, so it is not just any
"Card", it is a SimCard and should be called that way.

Change-Id: I2077ded44bc2297b8d478c5bd1895951b494efcc
---
M pySim-read.py
M pySim-shell.py
M pySim/cards.py
3 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pySim-read.py b/pySim-read.py
index 1f2e123..00194b4 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -34,7 +34,7 @@
 
 from pySim.commands import SimCardCommands
 from pySim.transport import init_reader, argparse_add_reader_args
-from pySim.cards import card_detect, Card, UsimCard, IsimCard
+from pySim.cards import card_detect, SimCard, UsimCard, IsimCard
 from pySim.utils import h2b, swap_nibbles, rpad, dec_imsi, dec_iccid, dec_msisdn
 from pySim.utils import format_xplmn_w_act, dec_st
 from pySim.utils import h2s, format_ePDGSelection
@@ -75,7 +75,7 @@
 	print("Reading ...")
 
 	# Initialize Card object by auto detecting the card
-	card = card_detect("auto", scc) or Card(scc)
+	card = card_detect("auto", scc) or SimCard(scc)
 
 	# Read all AIDs on the UICC
 	card.read_aids()
diff --git a/pySim-shell.py b/pySim-shell.py
index 59bfa28..7977ff5 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -37,7 +37,7 @@
 from pySim.exceptions import *
 from pySim.commands import SimCardCommands
 from pySim.transport import init_reader, ApduTracer, argparse_add_reader_args
-from pySim.cards import card_detect, Card
+from pySim.cards import card_detect, SimCard
 from pySim.utils import h2b, swap_nibbles, rpad, b2h, h2s, JsonEncoder, bertlv_parse_one
 from pySim.utils import dec_st, sanitize_pin_adm, tabulate_str_list, is_hex, boxed_heading_str
 from pySim.card_handler import card_handler
diff --git a/pySim/cards.py b/pySim/cards.py
index c41f343..c38b185 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -50,7 +50,7 @@
 		res += "\t%s # %s\n" % (addr_hex, addr)
 	return res
 
-class Card(object):
+class SimCard(object):
 
 	name = 'SIM'
 
@@ -310,7 +310,7 @@
 		len = self._scc.record_size(ef)
 		self._scc.update_record(ef, rec_no, "ff" * len, force_len=False, verify=True)
 
-class UsimCard(Card):
+class UsimCard(SimCard):
 
 	name = 'USIM'
 
@@ -388,7 +388,7 @@
 			(res, sw) = self._scc.update_binary(EF_USIM_ADF_map['UST'], content)
 		return sw
 
-class IsimCard(Card):
+class IsimCard(SimCard):
 
 	name = 'ISIM'
 
@@ -516,7 +516,7 @@
 				uiari_recs += "UICC IARI: Can't read, response code = %s\n" % (sw)
 		return uiari_recs
 
-class MagicSimBase(abc.ABC, Card):
+class MagicSimBase(abc.ABC, SimCard):
 	"""
 	Theses cards uses several record based EFs to store the provider infos,
 	each possible provider uses a specific record number in each EF. The
@@ -664,7 +664,7 @@
 	_ki_file = '6f1b'
 
 
-class FakeMagicSim(Card):
+class FakeMagicSim(SimCard):
 	"""
 	Theses cards have a record based EF 3f00/000c that contains the provider
 	information. See the program method for its format. The records go from
@@ -731,7 +731,7 @@
 			self._scc.update_record('000c', 1+i, entry)
 
 
-class GrcardSim(Card):
+class GrcardSim(SimCard):
 	"""
 	Greencard (grcard.cn) HZCOS GSM SIM
 	These cards have a much more regular ISO 7816-4 / TS 11.11 structure,
@@ -834,7 +834,7 @@
 		data, sw = self._scc._tp.send_apdu_checksw("0099000033" + par)
 
 
-class SysmoSIMgr2(Card):
+class SysmoSIMgr2(SimCard):
 	"""
 	sysmocom sysmoSIM-GR2
 	"""
@@ -1157,7 +1157,7 @@
 			if sw != '9000':
 				print("Programming ACC failed with code %s"%sw)
 
-class OpenCellsSim(Card):
+class OpenCellsSim(SimCard):
 	"""
 	OpenCellsSim
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2077ded44bc2297b8d478c5bd1895951b494efcc
Gerrit-Change-Number: 24142
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/7fdce60f/attachment.htm>


More information about the gerrit-log mailing list