Change in osmo-ttcn3-hacks[master]: BTS_Tests_SMSCB: ensure f_shutdown() is called in all test cases

laforge gerrit-no-reply at lists.osmocom.org
Wed Jun 30 08:01:09 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24768 )

Change subject: BTS_Tests_SMSCB: ensure f_shutdown() is called in all test cases
......................................................................

BTS_Tests_SMSCB: ensure f_shutdown() is called in all test cases

This fixes sporadic test case failures due to race conditions.

Change-Id: I3f2c327e1e44d5decd4a936f063af649687f950a
---
M bts/BTS_Tests_SMSCB.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests_SMSCB.ttcn b/bts/BTS_Tests_SMSCB.ttcn
index dda78fd..942bad3 100644
--- a/bts/BTS_Tests_SMSCB.ttcn
+++ b/bts/BTS_Tests_SMSCB.ttcn
@@ -1005,6 +1005,8 @@
 			setverdict(fail, "Segment ", i, " not received often enough");
 		}
 	}
+
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 
 /* Ensure only Paging Type 1 without ETWS Primary Notification are sent after disabling them */
@@ -1045,6 +1047,8 @@
 		setverdict(pass);
 		}
 	}
+
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 
 /* Ensure ETWS Primary Notification is passed from RSL to PCU interface */
@@ -1070,6 +1074,8 @@
 		setverdict(fail, "PCU socket timeout receiving APP INFO (ETWS)");
 		}
 	}
+
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3f2c327e1e44d5decd4a936f063af649687f950a
Gerrit-Change-Number: 24768
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/aad46a74/attachment.htm>


More information about the gerrit-log mailing list