Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix indention and readability of some comments

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 29 22:59:56 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24808 )


Change subject: BTS_Tests.ttcn: fix indention and readability of some comments
......................................................................

BTS_Tests.ttcn: fix indention and readability of some comments

Change-Id: I95c63c2d2498fec1915a2333d31d05f433560830
---
M bts/BTS_Tests.ttcn
1 file changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/24808/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 64e3fc2..cb37677 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2575,8 +2575,8 @@
 	}
 }
 
-/* see if the rsl meas res contains our expeced bs power level
-bs power set during assignment */
+/* See if the RSL MEASurement RESult contains expeced BS power level
+ * set  _during_ the CHANnel ACTIVation procedure. */
 private function f_TC_rsl_bs_pwr_static_ass(charstring id) runs on ConnHdlr {
 	f_l1_tune(L1CTL);
 	RSL.clear;
@@ -2598,8 +2598,8 @@
 	f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
 }
 
-/* see if the rsl meas res contains our expeced bs power level
-bs power set after assignment */
+/* See if the RSL MEASurement RESult contains expeced BS power level
+ * set  _after_ the CHANnel ACTIVation procedure. */
 private function f_TC_rsl_bs_pwr_static_power_control(charstring id) runs on ConnHdlr {
 	f_l1_tune(L1CTL);
 	RSL.clear;
@@ -2648,9 +2648,9 @@
 	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 
-/* target level -100, first rssi -90, ms power 7, expected increase to 7+6 within 6 seconds,
-second rssi -110, ms power 7+6, expected decrease to 7 within 6 seconds,
-These power levels are valid for all bands and require no special handling */
+/* Target level -100, first rssi -90, ms power 7, expected increase to 7+6 within 6 seconds,
+ * second rssi -110, ms power 7+6, expected decrease to 7 within 6 seconds.
+ * These power levels are valid for all bands and require no special handling. */
 private function f_TC_rsl_ms_pwr_dyn_ass_updown(charstring id) runs on ConnHdlr {
 	var uint5_t pwr_var := 7;
 	var SacchL1Header l1h;
@@ -2848,8 +2848,8 @@
 
 }
 
-/* see if we change the power level without receiving power parameters, which should not happen
-rsl chan act WITHOUT power parameters */
+/* See if the power level remains constant when MS Power Parameters IE
+ * is _absent_ in the CHANnel ACTIVation message. */
 private function f_TC_rsl_ms_pwr_dyn_active(charstring id) runs on ConnHdlr {
 	var SacchL1Header l1h;
 
@@ -2889,8 +2889,8 @@
 
 }
 
-/* see if we change the power level without receiving power parameters, which should not happen
-ms power control WITHOUT power parameters */
+/* See if the power level remains constant when MS Power Parameters IE
+ * is _absent_ in the CHANnel ACTIVation and MS Power Control messages. */
 private function f_TC_rsl_ms_pwr_dyn_active2(charstring id) runs on ConnHdlr {
 	var SacchL1Header l1h;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95c63c2d2498fec1915a2333d31d05f433560830
Gerrit-Change-Number: 24808
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210629/6171ee0e/attachment.htm>


More information about the gerrit-log mailing list