Change in osmo-bsc[master]: hodec2: fix low rxqual tch/h<->tch/f oscillation

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 29 20:25:47 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24797 )

Change subject: hodec2: fix low rxqual tch/h<->tch/f oscillation
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24797/1/src/osmo-bsc/handover_decision_2.c 
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24797/1/src/osmo-bsc/handover_decision_2.c@1194 
PS1, Line 1194: 	tch_f_with_low_rxqual = false;
> May be worth adding these as a separate helper API btw: "tch_f_with_low_rxqual(lchan, rxlev_current) […]
look what you did! two new patches!
but the code looks much nicer now, thx



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24797
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I96cd5a494e661ba3bb0b6d22d25a9968d2a6813c
Gerrit-Change-Number: 24797
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Jun 2021 20:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210629/3ff07fac/attachment.htm>


More information about the gerrit-log mailing list