Change in osmo-ttcn3-hacks[master]: msc: cipher mode: move cipher expect to new function

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 29 14:21:06 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758 )

Change subject: msc: cipher mode: move cipher expect to new function
......................................................................


Patch Set 2:

(2 comments)

applied review (and added some comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/library/BSSMAP_Templates.ttcn 
File library/BSSMAP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/library/BSSMAP_Templates.ttcn@549 
PS1, Line 549: template BSSMAP_IE_KC128 tr_BSSMAP_IE_Kc128(template OCT16 kc128) := {
> could be template (present) both as return and as argument, as "omit" is not permitted in both place […]
i haven't yet understood the benefit of adding keywords like that.

(i do experience a disadvantage via tooling: universal-ctags fails to pick up templates with "(foo)" keywords.
so looking up templates with such keywords becomes annoying, my usual tag jump fails and i need to start grepping...)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/msc/BSC_ConnectionHandler.ttcn@568 
PS1, Line 568:      runs
> strange indent of 4 chars? just move to previous line?
often the 'runs on' is written without any indent, in which case the 'git diff' no longer shows the function name in the diff chunk headers -- it shows the 'runs on' line instead. So that's why I added indent.
Wanted it to be less indented than the arguments ... i guess that's how i came up with 4 spaces here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1f775889fb801d441ea6c8b0f0c34718b814c09e
Gerrit-Change-Number: 24758
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 29 Jun 2021 14:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210629/0d0188bb/attachment.htm>


More information about the gerrit-log mailing list