Change in libosmocore[master]: Rename osmo dyn ts enums to contain SDCCH8
gerrit-no-reply at lists.osmocom.org
Tue Jun 29 09:14:50 UTC 2021
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24784 )
Change subject: Rename osmo dyn ts enums to contain SDCCH8
Patch Set 1:
> Patch Set 1:
> > Patch Set 1:
> > is this safe? what about a BSC that thinks SDCCH8 is within that type of dynamic channel, while the BTS version is older and only supports TCH + PDCH?
> I first through about adding anew BTS_FEATURE to signal "SDCCH8 support in osmo dyn ts". BUt anyway, even if there's no such feature, in that case I'd expect Chan Activation to fail and hence the TS to return to PDCH, so not a big problem. I can write a test to verify that situation.
I'd think the feature is a cleaner approach, rathe than trying something and see if/how it fails. We'd also have to test various old versions of osmo-bts-* if they all properly behave in that failure path, ...
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 29 Jun 2021 09:14:50 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log