Change in osmo-ccid-firmware[master]: 7816 fsm: don't error on card removal in tpdu wait state

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 25 08:07:27 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/24770 )

Change subject: 7816 fsm:  don't error on card removal in tpdu wait state
......................................................................

7816 fsm:  don't error on card removal in tpdu wait state

This led to a weird failed transfer _after_ poweroff of the slot upon
card removal, which is.... not what should happen, at least in case the
ccid side does not ignore it.

Change-Id: Ibabcc938d64a057ff60a2337a1320d0afb94032b
---
M ccid_common/iso7816_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c
index 7207245..7ea842d 100644
--- a/ccid_common/iso7816_fsm.c
+++ b/ccid_common/iso7816_fsm.c
@@ -438,7 +438,7 @@
 		if(fi->state == ISO7816_S_WAIT_PPS_RSP || fi->state == ISO7816_S_IN_PPS_RSP)
 			ip->user_cb(fi, ISO7816_E_PPS_UNSUPPORTED_IND, 0, ppp->tx_cmd);
 
-		if(fi->state == ISO7816_S_WAIT_TPDU || fi->state == ISO7816_S_IN_TPDU)
+		if(fi->state == ISO7816_S_IN_TPDU)
 			ip->user_cb(fi, ISO7816_E_TPDU_FAILED_IND, 0, tpdup->tpdu);
 
 		osmo_fsm_inst_state_chg(fi, ISO7816_S_RESET, 0, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/24770
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ibabcc938d64a057ff60a2337a1320d0afb94032b
Gerrit-Change-Number: 24770
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210625/61af453e/attachment.htm>


More information about the gerrit-log mailing list