Change in osmo-ttcn3-hacks[master]: msc: cipher mode: move cipher expect to new function

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 24 11:31:24 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758 )

Change subject: msc: cipher mode: move cipher expect to new function
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/library/BSSMAP_Templates.ttcn 
File library/BSSMAP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/library/BSSMAP_Templates.ttcn@549 
PS1, Line 549: template BSSMAP_IE_KC128 tr_BSSMAP_IE_Kc128(template OCT16 kc128) := {
could be template (present) both as return and as argument, as "omit" is not permitted in both places.  looks like the code here misses this a lot.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758/1/msc/BSC_ConnectionHandler.ttcn@568 
PS1, Line 568:      runs
strange indent of 4 chars? just move to previous line?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24758
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1f775889fb801d441ea6c8b0f0c34718b814c09e
Gerrit-Change-Number: 24758
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 24 Jun 2021 11:31:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210624/a5159d57/attachment.htm>


More information about the gerrit-log mailing list