Change in libosmocore[master]: socket: add function to wait until a socket becomes writeable

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 24 10:43:11 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24435 )

Change subject: socket: add function to wait until a socket becomes writeable
......................................................................


Patch Set 7:

I don't understand why we a) need a new function in the library and b) introduce functions for blocking semantics in a codebase that's entirely non-blocking and asynchronous event processing.

When the non-blocking connect() fails, the associated file descriptor should receive a notification, which is processed by libosmocore/select.c and dispatched via poll_disp_fds() to the user application registered callback.  In that callback, the user application should be able to get the error status using the getsockopt stated here.  All async, no new libosmocore function needed.  Am I missing something?

Whihc of the POLL* flags is (or are) set in that situation? libosmocore select main loop allows to set POLLIN, POLLHUP, POLLERR, POLLOUT, POLLPRI.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24435
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c68185120fa2a6c9b6cb8aa2a25232a44ff5508
Gerrit-Change-Number: 24435
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Jun 2021 10:43:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210624/1343f1ef/attachment.htm>


More information about the gerrit-log mailing list