Change in osmo-pcu[master]: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 23 17:11:35 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24747 )

Change subject: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/24747/2/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/24747/2/src/pdch.cpp@336 
PS2, Line 336: it may be NULL
> So it may be NULL, but you're unconditionally dereferencing it below by passing to ms_dl_tbf() and m […]
ms pointer as would have been obtained by bts_ms_by_tlli could be null.
On the other hand, since we arrived here, because there was a registered TBF expecting a ctrl ack, we are sure tbf->ms() is nevel null, because a tbf always has an associated ms object.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I666ed5d157f42e74956fa49fc9eea85d27e63d44
Gerrit-Change-Number: 24747
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jun 2021 17:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/72bd5df9/attachment.htm>


More information about the gerrit-log mailing list