Change in libosmocore[master]: gprs_ns2_vty: dump_nsvc: change output depending on NSVCI

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 23 11:53:04 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24686 )

Change subject: gprs_ns2_vty: dump_nsvc: change output depending on NSVCI
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

The VTY tests need an update, otherwise looks it good to me.

https://gerrit.osmocom.org/c/libosmocore/+/24686/1/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/24686/1/src/gb/gprs_ns2_vty.c@1876 
PS1, Line 1876: 	if (nsvc->nsvci_is_valid)
Jenkins fails because of the VTY tests...

Mismatch:
Expect:
'   NSVCI none: RECOVERING PERSIST data_weight=1 sig_weight=1 udp)[127.0.0.14]:42999<>[127.0.0.15]:9496'
Got:
'   RECOVERING PERSIST sig_weight=1 data_weight=1 udp)[127.0.0.14]:42999<>[127.0.0.15]:9496'



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24686
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaadc806a9136436468e2b02eb0bc1f4570a10ecc
Gerrit-Change-Number: 24686
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jun 2021 11:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/0d77f3c2/attachment.htm>


More information about the gerrit-log mailing list