Change in osmo-pcu[master]: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 23 11:51:51 UTC 2021


Hello Jenkins Builder, fixeria, dexter, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/24747

to look at the new patch set (#2).

Change subject: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack
......................................................................

pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack

If bts_ms_by_tlli() at the start of the function fails, ms could be
NULL. As a result "ms->nacc" access at the end of the function would
crash.
Solution:
In the function, we get the related expected TBF from pdch_ulc, and we only
continue if a TBF is found. Since tbf objects are always expected to
have a GprsMs, simply gather it from there.

Change-Id: I666ed5d157f42e74956fa49fc9eea85d27e63d44
---
M src/pdch.cpp
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/24747/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I666ed5d157f42e74956fa49fc9eea85d27e63d44
Gerrit-Change-Number: 24747
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/69e94941/attachment.htm>


More information about the gerrit-log mailing list