Change in osmo-pcu[master]: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 23 11:39:20 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24747 )

Change subject: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

The patch looks correct to me. I might have overlooked something, but I think it is even possible to get rid of the ms variable completely.

https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp@316 
PS1, Line 316: 			fn, tlli, trx_no(), ts_no);
maybe we can get rid of the ms variable completely (see below) if we just do:
if (bts_ms_by_tlli(bts(), tlli, GSM_RESERVED_TMSI))


https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp@336 
PS1, Line 336: 	/* Gather MS from TBF, since it may be NULL or may have been merged during update_ms */
maybe we can drop this if we use tbf->ms() below (nacc)?


https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp@413 
PS1, Line 413: 	}
We can not just use tbf->ms() here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I666ed5d157f42e74956fa49fc9eea85d27e63d44
Gerrit-Change-Number: 24747
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jun 2021 11:39:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/31d00cdb/attachment.htm>


More information about the gerrit-log mailing list