Change in simtrace2[master]: cardem: free the buf

Hoernchen gerrit-no-reply at lists.osmocom.org
Tue Jun 22 15:00:38 UTC 2021


Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24740 )

Change subject: cardem: free the buf
......................................................................

cardem: free the buf

This leak was probably hard to notice since config commands are usually
rarely sent.

Change-Id: I21411ef78a32a5258a7008272774cdb83119b413
---
M firmware/libcommon/source/mode_cardemu.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, approved



diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c
index a357f15..b9971ed 100644
--- a/firmware/libcommon/source/mode_cardemu.c
+++ b/firmware/libcommon/source/mode_cardemu.c
@@ -705,6 +705,7 @@
 	case SIMTRACE_MSGT_BD_CEMU_CONFIG:
 		cfg = (struct cardemu_usb_msg_config *) msg->l2h;
 		card_emu_set_config(ci->ch, cfg, msgb_l2len(msg));
+		usb_buf_free(msg);
 		break;
 	case SIMTRACE_MSGT_BD_CEMU_STATS:
 	default:

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24740
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I21411ef78a32a5258a7008272774cdb83119b413
Gerrit-Change-Number: 24740
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210622/992b7eb1/attachment.htm>


More information about the gerrit-log mailing list