Change in libosmocore[master]: add Kc128 to gsm0808 Create Ciphering Command

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 22 09:26:29 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24722 )

Change subject: add Kc128 to gsm0808 Create Ciphering Command
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h@73 
PS3, Line 73: 	bool more_items; /*< always set this to false */
FYI, in case you envision to have several versions of the struct, a usual way (see for instance Windows APIs) to do so is to have a "size" field in the struct which needs to be set to sizeof(struct type) before passing it to the API. This way the API implementation can find out how far in the struct it can go (or simply which version of the struct was passed to it).



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib3906085e0c6e5a496a9f755f0f786238a86ca34
Gerrit-Change-Number: 24722
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Jun 2021 09:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210622/fbfc2b27/attachment.htm>


More information about the gerrit-log mailing list